Update celery versions #161
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello Contributor,👋👋 Thank You For Opening This Pull Request 🎉🎉
Welcome to SpaceYaTech
We are the fastest growing Africa Open-Source Community Looking To Change The Way Young Africans Get Started In Technology.
JOIN US | THRIVE | GROW
It's great having you contribute to this project
Welcome to the community 🤓 🍿 **Fun facts** - we eat bugs 🐛🐛🐛🐛 for breakfast 🥣This Pull request has been queued for `review`
Sit tight the maintainers are on your case.Soon the maintainers/owner will review it and provide you with feedback suggestions.
If you think it's something urgent, feel free to reach out
There was a problem hiding this comment.
This PR introduces necessary updates to resolve an issue encountered during the build process. After reviewing the changes and understanding the reasoning, I approve it with the following observations:
Celery upgrade: The version bump from 5.2.7 to 5.4.0 was necessary to resolve an import error (cannot import name 'Celery' from 'celery'), similar to the issue discussed in python/importlib_metadata#411. Updating to the latest version unblocked the build process. While this fix is important, thorough testing is still recommended to ensure compatibility with the task processing workflows.
Kombu upgrade: With Kombu being closely tied to Celery for message passing, the version upgrade from 5.2.4 to 5.4.2 ensures better compatibility with the updated Celery version. It's crucial to review the Kombu changelog and verify no breaking changes affect task queueing behavior.
Timezone data update: The update of tzdata to version 2024.2 ensures that the project is using the latest timezone information, which is particularly important for applications dealing with scheduling and international time zones.
The updates address a critical issue and bring the dependencies up to date. I recommend testing the changes thoroughly in a staging environment to confirm the system's stability and functionality before deploying to production.
Great job!
|
Did you confirm that the updated dependencies are compatible with Python 3.10, which is used to build the application? Compatibility checks are crucial to ensure stability and functionality? |
|
This workflow that runs against pull requests and merges to main is set up with Python 3.10. This successful actions build against the PR implies compatibility |
|
I agree 💯 |
Description
Was getting a
cannot import name 'Celery' from 'celery'error while trying to build the codeSimilar to discussion here: python/importlib_metadata#411
Updating the libraries involved unblocked me
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist: